----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/#review73592 -----------------------------------------------------------
Ship it! +1 if the comment below is fixed. core/src/test/scala/unit/kafka/server/ConflictBrokerRegistrationTest.scala <https://reviews.apache.org/r/31260/#comment119989> I'd move this to existing tests for server startup/shutdown. For example, ServerStartupTest. Let's not create an entire test suite just for this purpose. - Neha Narkhede On Feb. 23, 2015, 5:11 a.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31260/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 5:11 a.m.) > > > Review request for kafka. > > > Bugs: kafka-1971 > https://issues.apache.org/jira/browse/kafka-1971 > > > Repository: kafka > > > Description > ------- > > address review comments > > > remove unused util method > > > add unit test > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaHealthcheck.scala > 4acdd70fe9c1ee78d6510741006c2ece65450671 > core/src/main/scala/kafka/server/KafkaServer.scala > 7e5ddcb9be8fcef3df6ebc82a13ef44ef95f73ae > core/src/main/scala/kafka/utils/ZkUtils.scala > c78a1b6ff4213e13cabccd21a7b40cfeddbfb237 > core/src/test/scala/unit/kafka/server/ConflictBrokerRegistrationTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/31260/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
