> On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote:
> > Ah, now I get what "dedupe buffer" refers to :)
> > 
> > I never managed to reproduce the oom, but this looks like the right fix.

This happened consistently for me, which provided good motivation to figure out 
how to fix it :) It looks like the tests use the default JVM settings 
(build.gradle has overrides for compile, but not for test), so the 500 MB 
allocation was always failing since it obviously exceeds the default 128 MB 
heap. Now I'm wondering if other people are running with different settings. 
Maybe if you have a gradle daemon running that was started with a bigger max 
heap size?


- Ewen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31447/#review74200
-----------------------------------------------------------


On Feb. 25, 2015, 11:27 p.m., Ewen Cheslack-Postava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31447/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 11:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1881
>     https://issues.apache.org/jira/browse/KAFKA-1881
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1881: Fix out of memory error in testDeleteTopicWithCleaner by making 
> the dedupe buffer much smaller.
> 
> 
> Diffs
> -----
> 
>   core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 
> 0cbd72684a0cc6fe9f1fba2dc834de675b2eb994 
> 
> Diff: https://reviews.apache.org/r/31447/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ewen Cheslack-Postava
> 
>

Reply via email to