> On March 11, 2015, 8:39 p.m., Jiangjie Qin wrote:
> > Works for me but still see the following line:
> > there were 12 feature warning(s); re-run with -feature for details
> > I tried ./gradlew jar -feature, but it seems does not work at all. If this 
> > is the related issue, can we solve it in this patch? Otherwise we can 
> > create another ticket to address it.

Thanks for looking at this Jiangjie,

In order for feature warnings to display, you have to add 
scalaCompileOptions.additionalParameters = ["-feature"] below line 131 in 
build.gradle at the root of the project. I posted the verbose output from 
enabling the flag on the ticket: 
https://issues.apache.org/jira/browse/KAFKA-1054?focusedCommentId=14356280&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14356280.

Bottom line is: I don't think we can fix these feature warnings until Kafka 
stops supporting scala 2.9. I get these build errors when trying to build a 2.9 
jar with the language imports brought in:


    
/Users/blake/src/kafka/core/src/main/scala/kafka/javaapi/Implicits.scala:19: 
object language is not a member of package scala
    import scala.language.implicitConversions

    * Try:
    Run with --stacktrace option to get the stack trace. Run with --info or 
--debug option to get more log output.

    BUILD FAILED

Does that make sense?


- Blake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31925/#review76122
-----------------------------------------------------------


On March 11, 2015, 4:35 a.m., Blake Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31925/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 4:35 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1054
>     https://issues.apache.org/jira/browse/KAFKA-1054
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Brought the patch outlined [here](https://reviews.apache.org/r/25461/diff/) 
> up to date with the latest trunk and fixed 2 more lingering compiler warnings.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala b700110 
>   core/src/main/scala/kafka/coordinator/DelayedJoinGroup.scala df60cbc 
>   core/src/main/scala/kafka/server/KafkaServer.scala dddef93 
>   core/src/main/scala/kafka/utils/Utils.scala 738c1af 
>   core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala b46daa4 
> 
> Diff: https://reviews.apache.org/r/31925/diff/
> 
> 
> Testing
> -------
> 
> Ran full test suite.
> 
> 
> Thanks,
> 
> Blake Smith
> 
>

Reply via email to