----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31927/#review76075 -----------------------------------------------------------
Thanks for the patch. I do see the unit test time goes down from 12 mins to 9.5 mins on my mac. A few comments below. core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31927/#comment123478> The backoff needs to be added after line 104, instead of here. Basically, we will back off if we hit a socket exception during fetch. Here, we are just getting an error on an individual partition. So, there is no need to backoff. core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/31927/#comment123469> How about making the default 1000 ms? core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/31927/#comment123468> The rest of the timeouts are of Int. It may be useful to move everthing to long in the future, but that can be done in a separate jira. - Jun Rao On March 11, 2015, 5:33 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31927/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 5:33 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 8c281d4668f92eff95a4a5df3c03c4b5b20e7095 > core/src/main/scala/kafka/server/KafkaConfig.scala > 48e33626695ad8a28b0018362ac225f11df94973 > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > d6d14fbd167fb8b085729cda5158898b1a3ee314 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > c124c8df5b5079e5ffbd0c4ea359562a66aaf317 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 52c79201af7c60f9b44a0aaa09cdf968d89a7b87 > > Diff: https://reviews.apache.org/r/31927/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
