-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29301/
-----------------------------------------------------------
(Updated March 12, 2015, 11:04 a.m.)
Review request for kafka.
Bugs: KAFKA-1694
https://issues.apache.org/jira/browse/KAFKA-1694
Repository: kafka
Description (updated)
-------
KAFKA-1694 - introduced new type for Wire protocol, ported
ClusterMetadataResponse to it
KAFKA-1694 - Split Admin RQ/RP to separate messages
KAFKA-1694 - Admin commands can be handled only by controller;
DeleteTopicCommand NPE fix
KAFKA-1776 - Ported ConsumerGroupOffsetChecker
KAFKA-1776 - Ported PreferredReplicaElectionTool and ReassignPartitionsTool to
CLI
KAFKA-1694 - ReviewBoard 29301 code review fixes
KAFKA-1694 - Data for ReassignPartitions and PreferredReplicaLeaderElection is
in json string
KAFKA-1694 - Added logging
KAFKA-1694 - fixed misprint in schema
KAFKA-1694 - DescribeTopicCommand supports all flags that TopicCommand does
KAFKA-1694 - Fixed compile error for new Selector constructor
KAFKA-1694 - Fixed ConsumerGroupChecker sends DescribeTopicResponse instead of
ConsumerGroupOffsetsResponse
KAFKA-1694 - Introduced AbstractAdminRequest/Response to avoid code duplication
for sending admin requests / receiving response.
KAFKA-1694 - Code review fix: /core shouldn't depend on /tools
KAFKA-1694 - Code review fix: normalized config field in Create- and
AlterTopicRequest
KAFKA-1694 - Remove server RQ/RP messages, clients' classes are used instead
KAFKA-1694 - Remove ConsumerGroupOffsets RQ/RP - a separate KIP will be created
KAFKA-1694 - Remove MaybeOf type, clean up dead code
KAFKA-1694 - Post rebase merge conflicts fixes
KAFKA-1694 - Added Protocol errors
KAFKA-1694 - Bugfix - incorrect error
Diffs (updated)
-----
bin/kafka.sh PRE-CREATION
bin/windows/kafka.bat PRE-CREATION
build.gradle 0f0fe60a74542efa91a0e727146e896edcaa38af
checkstyle/import-control.xml cca4b38ec766028a604f88a1c63228e40df24573
clients/src/main/java/org/apache/kafka/common/ConfigEntry.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
07aba71303bc1303dbe05e4b121f73f7ad27fdb5
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
ce18a6ce7ed31420cdbec6926a9cd04fa4c806b1
clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
101f382170ad6740b3f8ff2d27b93a64874a857f
clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/AbstractAdminRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/AbstractAdminResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/AlterTopicRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/AlterTopicResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/CreateTopicRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/CreateTopicResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/DeleteTopicRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/DeleteTopicResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/DescribeTopicOutput.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/DescribeTopicRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/DescribeTopicResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/ListTopicsRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/ListTopicsResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/PreferredReplicaLeaderElectionRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/PreferredReplicaLeaderElectionResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/ReassignPartitionsRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/ReassignPartitionsResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/TopicConfigDetails.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/TopicPartitionDetails.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/VerifyReassignPartitionsRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/admin/VerifyReassignPartitionsResponse.java
PRE-CREATION
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
13237fd72da5448a3d596b882fef141f336f827d
config/tools-log4j.properties 52f07c96019b4083fc78f62cfb0a81080327e847
core/src/main/scala/kafka/api/ApiUtils.scala
1f80de1638978901500df808ca5133308c9d1fca
core/src/main/scala/kafka/api/ClusterMetadaRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/ClusterMetadataResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/RequestKeys.scala
c24c0345feedc7b9e2e9f40af11bfa1b8d328c43
core/src/main/scala/kafka/api/admin/AlterTopicRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/AlterTopicResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/CreateTopicRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/CreateTopicResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/DeleteTopicRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/DeleteTopicResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/DescribeTopicRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/DescribeTopicResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/ListTopicsRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/ListTopicsResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/PreferredReplicaLeaderElectionRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/PreferredReplicaLeaderElectionResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/ReassignPartitionsRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/ReassignPartitionsResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/VerifyReassignPartitionsRequestAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/api/admin/VerifyReassignPartitionsResponseAndHeader.scala
PRE-CREATION
core/src/main/scala/kafka/common/AdminRequestFailedException.scala
PRE-CREATION
core/src/main/scala/kafka/common/ErrorMapping.scala
eb1eb4a703098253d0aae79577084569177768d1
core/src/main/scala/kafka/common/NotControllerReceivedAdminRequestException.scala
PRE-CREATION
core/src/main/scala/kafka/controller/ControllerChannelManager.scala
c582191636f6188c25d62a67ff0315b56f163133
core/src/main/scala/kafka/server/KafkaApis.scala
35af98f0bc1b6a50bd1d97a30147593f8c6a422d
core/src/main/scala/kafka/server/MetadataCache.scala
6aef6e4508ecadbbcc1e12bed2054547b7aa333e
core/src/main/scala/kafka/server/TopicCommandHelper.scala PRE-CREATION
core/src/main/scala/kafka/tools/PreferredReplicaLeaderElectionHelper.scala
PRE-CREATION
core/src/main/scala/kafka/tools/ReassignPartitionsHelper.scala PRE-CREATION
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
fba852afa1b2f46b61e2fd12c38c821ba04e9cc6
settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45
tools/src/main/java/org/apache/kafka/cli/BaseCommandOpts.java PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/Boot.java PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/RequestDispatcher.java PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/Shell.java PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/AlterTopicCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/ClearScreenCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/Command.java PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/CreateTopicCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/DeleteTopicCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/DescribeTopicCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/ExitCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/ListTopicsCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/PreferredReplicaLeaderElectionCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/PrintHelpCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/ReassignPartitionsCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/command/TopicSwitchCommand.java
PRE-CREATION
tools/src/main/java/org/apache/kafka/cli/util/StringUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/29301/diff/
Testing
-------
Thanks,
Andrii Biletskyi
