----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76517 -----------------------------------------------------------
Thanks for the patch. A few comments below. core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/31967/#comment124082> This is actualy not a reliable check for isr expansion. Consider a case where there are 3 replicas a, b, and c. Suppose that a and b are in isr and c is not. At some point, c fully catches up to LEO. Its lagBeginTimeMs is set to -1 and we are about to call maybeExpandIsr(). Before that happens, a and b both advance its LEO and HW also advances. Now, we do the check in maybeExpandIsr() and add c to isr. However, c now misses messages btw the LEO it sees and the new HW. The original check is more reliable for isr expansion. core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala <https://reviews.apache.org/r/31967/#comment124083> The comment says 10, which is inconsistent with the code change below. core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala <https://reviews.apache.org/r/31967/#comment124084> "catch up to only 10" is no longer accurate. - Jun Rao On March 12, 2015, 8:42 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31967/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 8:42 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1546 > https://issues.apache.org/jira/browse/KAFKA-1546 > > > Repository: kafka > > > Description > ------- > > PATCH for KAFKA-1546 > > Brief summary of changes: > - Added a lagBegin metric inside Replica to track the lag in terms of time > since the replica did not read from the LEO > - Using lag begin value in the check for ISR expand and shrink > - Removed the max lag messages config since it is no longer necessary > - Returning the initialLogEndOffset in LogReadResult corresponding to the the > LEO before actually reading from the log. > - Unit test cases to test ISR shrinkage and expansion > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > c4bf48a801007ebe7497077d2018d6dffe1677d4 > core/src/main/scala/kafka/cluster/Replica.scala > bd13c20338ce3d73113224440e858a12814e5adb > core/src/main/scala/kafka/server/KafkaConfig.scala > 48e33626695ad8a28b0018362ac225f11df94973 > core/src/main/scala/kafka/server/ReplicaManager.scala > c5274822c57bf3c1f9e4135c0bdcaa87ee50ce20 > core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala > 92152358c95fa9178d71bd1c079af0a0bd8f1da8 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > c124c8df5b5079e5ffbd0c4ea359562a66aaf317 > core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala > 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3 > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > efb457334bd87e4c5b0dd2c66ae1995993cd0bc1 > > Diff: https://reviews.apache.org/r/31967/diff/ > > > Testing > ------- > > > Thanks, > > Aditya Auradkar > >
