----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review76815 -----------------------------------------------------------
Ship it! Ship It! - Guozhang Wang On March 17, 2015, 8:47 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31706/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 8:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1997 > https://issues.apache.org/jira/browse/KAFKA-1997 > > > Repository: kafka > > > Description > ------- > > move shutdown hook registration before creating producer and consumer > streams, so mirror maker can be shutdown correctly if error occur during > consumer stream creation. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 87b925c7332470de59a5b098d51c4bf0dfab8b8f > > Diff: https://reviews.apache.org/r/31706/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
