[
https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366543#comment-14366543
]
TAO XIAO commented on KAFKA-1997:
---------------------------------
[~becket_qin] I think I found a bug in MirrorMaker.scala. As show in below code
block rebalanceListenerArgs gets passed into MirrorMakerMessageHandler
constructor instead of messageHandlerArgs
{code:title=MirrorMaker.scala|borderStyle=solid}
messageHandler = {
if (customMessageHandlerClass != null) {
if (messageHandlerArgs != null)
Utils.createObject[MirrorMakerMessageHandler](customMessageHandlerClass,
rebalanceListenerArgs)
else
Utils.createObject[MirrorMakerMessageHandler](customMessageHandlerClass)
} else {
defaultMirrorMakerMessageHandler
}
}
{code}
> Refactor Mirror Maker
> ---------------------
>
> Key: KAFKA-1997
> URL: https://issues.apache.org/jira/browse/KAFKA-1997
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
> Attachments: KAFKA-1997.patch, KAFKA-1997_2015-03-03_16:28:46.patch,
> KAFKA-1997_2015-03-04_15:07:46.patch, KAFKA-1997_2015-03-04_15:42:45.patch,
> KAFKA-1997_2015-03-05_20:14:58.patch, KAFKA-1997_2015-03-09_18:55:54.patch,
> KAFKA-1997_2015-03-10_18:31:34.patch, KAFKA-1997_2015-03-11_15:20:18.patch,
> KAFKA-1997_2015-03-11_19:10:53.patch, KAFKA-1997_2015-03-13_14:43:34.patch,
> KAFKA-1997_2015-03-17_13:47:01.patch
>
>
> Refactor mirror maker based on KIP-3
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
