[
https://issues.apache.org/jira/browse/KAFKA-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369898#comment-14369898
]
Parth Brahmbhatt commented on KAFKA-2032:
-----------------------------------------
I keep forgetting the kafka post-review publishes by default, I am in habit of
posting a review , reviewing it my self and make changes and re-post. Sorry for
the spamming.
I have the changes for both scala and java configs. The original default value
was "blah" which by default translated to range, see below. I have updated it
to have default value of "range".
object PartitionAssignor {
def createInstance(assignmentStrategy: String) = assignmentStrategy match {
case "roundrobin" => new RoundRobinAssignor()
case _ => new RangeAssignor()
}
}
> ConsumerConfig doesn't validate partition.assignment.strategy values
> --------------------------------------------------------------------
>
> Key: KAFKA-2032
> URL: https://issues.apache.org/jira/browse/KAFKA-2032
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1.2
> Reporter: Jason Rosenberg
> Assignee: Parth Brahmbhatt
> Attachments: KAFKA-2032.patch, KAFKA-2032_2015-03-19_11:42:07.patch,
> KAFKA-2032_2015-03-19_11:44:48.patch, KAFKA-2032_2015-03-19_11:47:24.patch
>
>
> In the ConsumerConfig class, there are validation checks to make sure that
> string based configuration properties conform to allowed values. However,
> this validation appears to be missing for the partition.assignment.strategy.
> E.g. there is validation for autooffset.reset and offsets.storage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
