----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32440/#review77593 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java <https://reviews.apache.org/r/32440/#comment125718> Since its a Producer level config, is this change needed. We can keep it as an instance variable. Also since the compression type does not change, the "private final" makes it more clear. What do you think? - Mayuresh Gharat On March 24, 2015, 3:51 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32440/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 3:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2043 > https://issues.apache.org/jira/browse/KAFKA-2043 > > > Repository: kafka > > > Description > ------- > > CompressionType is passed in each RecordAccumulator append > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > feda9c922d7dab17e424f8e6f0aa0a3f968e3729 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > 88b4e4fbf3bf6fb6d2f90551a792b95d4cd51c40 > > clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java > e379ac89c9a2fbfe750d6b0dec693b7eabb76204 > > clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java > 24274a64885fadd0e9318de2beb232218ddd52cd > > Diff: https://reviews.apache.org/r/32440/diff/ > > > Testing > ------- > > > Thanks, > > Grant Henke > >
