[ 
https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387573#comment-14387573
 ] 

ASF GitHub Bot commented on KAFKA-873:
--------------------------------------

GitHub user atdixon opened a pull request:

    https://github.com/apache/kafka/pull/53

    curator + exhibitor integration

    My motivation for introducing curator to kafka was to get optional 
exhibitor support, however I noticed this  is also a solution to ticket 
KAFKA-873 (https://issues.apache.org/jira/browse/KAFKA-873).
    
    Structurally I believe the code is sound, however some tests are blocking 
which I believe is duet o races related to in-memory Zookeeper but not entirely 
sure. Am looking into it and testing outside of in-memory ZK, as well. But 
would love comments/discussion on this PR. I imagine exhibitor support is 
something that many are interested in, especially those of us in AWS & cloud 
environments.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atdixon/kafka exhibitor-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 3526d5664fa87b2d3f0e6e35bd5b060639df4ead
Author: Aaron Dixon <atdi...@gmail.com>
Date:   2015-03-30T23:15:16Z

    curator + exhibitor integration

----


> Consider replacing zkclient with curator (with zkclient-bridge)
> ---------------------------------------------------------------
>
>                 Key: KAFKA-873
>                 URL: https://issues.apache.org/jira/browse/KAFKA-873
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Scott Clasen
>            Assignee: Grant Henke
>
> If zkclient was replaced with curator and curator-x-zkclient-bridge it would 
> be initially a drop-in replacement
> https://github.com/Netflix/curator/wiki/ZKClient-Bridge
> With the addition of a few more props to ZkConfig, and a bit of code this 
> would open up the possibility of using ACLs in zookeeper (which arent 
> supported directly by zkclient), as well as integrating with netflix 
> exhibitor for those of us using that.
> Looks like KafkaZookeeperClient needs some love anyhow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to