> On April 2, 2015, 1:38 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, lines 431-437 > > <https://reviews.apache.org/r/30809/diff/4/?file=903374#file903374line431> > > > > Could we add a description of the test (what kind of data is generated, > > how does consumer to the verification, what kind of output is generated, > > etc)?
The data which is generated is very simple - increasing sequence of longs with timestamp. The producer keeps track of the newest sequence number, timestamp which it has sent. The consumer keeps track of the last sequence number and timestamp which it has received. The system test will interrupt the CVT and compare the sequence numbers between the producer and the sender. If they do not line up then it is an error. (If either the producer or consumer threads terminate un-expectedly before they have been interrupted it will be flagged as an error) If the test fails then the data logs from the producer and consumer are not removed and can be inspected. The idea behind putting the consumer and producer in the same JVM was orthogonal to system test and was in case it is used in a test cluster hosting other topics it makes easy to get hands on some things like delta etc. However, I think there is very strong objection to adopting this for system tests which are short-lived in nature. Unless there is support for the approach I have taken so far I plan to revert to the existing approach of spawning multiple JVMs for producer and consumer. I will change the bash script to be in python similar to what other system tests do. > On April 2, 2015, 1:38 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, lines 440-454 > > <https://reviews.apache.org/r/30809/diff/4/?file=903374#file903374line440> > > > > Could we add a description of each command line option? I need to add more documentation. I will add this in. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review78630 ----------------------------------------------------------- On March 23, 2015, 6:54 p.m., Abhishek Nigam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30809/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 6:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1888 > https://issues.apache.org/jira/browse/KAFKA-1888 > > > Repository: kafka > > > Description > ------- > > Updated the RB with Gwen's comments, Beckett's comments and a subset of > Guozhang's comments > > > Diffs > ----- > > bin/kafka-run-class.sh 881f578a8f5c796fe23415b978c1ad35869af76e > core/src/main/scala/kafka/tools/ContinuousValidationTest.java PRE-CREATION > core/src/main/scala/kafka/utils/ShutdownableThread.scala > fc226c863095b7761290292cd8755cd7ad0f155c > system_test/broker_upgrade/bin/test-broker-upgrade.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/30809/diff/ > > > Testing > ------- > > Scripted it to run 20 times without any failures. > Command-line: broker-upgrade/bin/test.sh <dir1> <dir2> > > > Thanks, > > Abhishek Nigam > >
