----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32866/#review79084 -----------------------------------------------------------
Thanks for the patch. A few comments below. Also, could you rebase? core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/32866/#comment128180> Could we do foreach instead of map? core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/32866/#comment128179> Could we do foreach instead of map? There are a few other places like this. core/src/test/scala/unit/kafka/producer/ProducerTest.scala <https://reviews.apache.org/r/32866/#comment128181> indentation core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala <https://reviews.apache.org/r/32866/#comment128186> indentation core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala <https://reviews.apache.org/r/32866/#comment128189> Is there a particular reason to remove the test on verifyNonDaemonThreadsStatus? core/src/test/scala/unit/kafka/utils/TestUtils.scala <https://reviews.apache.org/r/32866/#comment128191> Is there a reason to change the default? In the most common case when we are just starting a single broker in a cluster, we want to enable controlled shutdown so that we know that it won't block. - Jun Rao On April 5, 2015, 8:54 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32866/ > ----------------------------------------------------------- > > (Updated April 5, 2015, 8:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1954 > https://issues.apache.org/jira/browse/KAFKA-1954 > > > Repository: kafka > > > Description > ------- > > KAFKA-1954. Speed up unit tests. > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala > 99ac9230f63105a2942bec8fe2febde8a7e48b2e > core/src/test/scala/unit/kafka/admin/AdminTest.scala > 0305f704b66a257d1ae732550793dbb2536e7ac1 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 61cc6028dd7c9a2eec2d9cbe6947764655801eee > core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala > 28e3122b71ca26c2fdf81649b0586ebc94e105fe > core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala > 130b20533d35499e0d4e0403d521b246610bd325 > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 56b1b8c004b1719c45b1e7bc9580e3638e3438ac > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > 7c87b81b12366eb04144ec4005a5fda0d0260eea > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 18361c13fd0b8cd60f45249507b76d53e6001c12 > core/src/test/scala/unit/kafka/producer/ProducerTest.scala > a7ca14227edd8ca1a65122350fe4740d455f0c5c > core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala > b0112402e7813cf4f5247e90af87482c340bd000 > core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala > 3d4258f8b31c1f2c7e0351fb6df9a96234e11d1d > core/src/test/scala/unit/kafka/server/LogOffsetTest.scala > 496bf0ddfc2e7872dc187ad85de5e845c6258604 > core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala > 92e49df6964230753762aa359191a6ede337d3ac > core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala > a67cc37d542de0df0df24224b9d8db5472ecaf27 > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > 2bfaeb307094b0fba67a1976b7f87591ca36a45c > core/src/test/scala/unit/kafka/utils/TestUtils.scala > f4518255a2bcf3ae3ccb19b9e2ff0b70c613966a > > Diff: https://reviews.apache.org/r/32866/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
