[
https://issues.apache.org/jira/browse/KAFKA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-346:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
This is already fixed on trunk.
> Don't call commitOffsets() during rebalance
> -------------------------------------------
>
> Key: KAFKA-346
> URL: https://issues.apache.org/jira/browse/KAFKA-346
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.7, 0.7.1, 0.8.0
> Reporter: Peter Romianowski
> Attachments: KAFKA-346.patch
>
>
> A sample use-case
> If I read the source correctly then offsets can be committed at any
> time (whenever there is a change in consumer or broker zk registry).
> Our application doesn't use auto-commit in order to batch some
> messages together, process them and if everything went fine, we call
> commitOffsets(). If, for any reason, the processing of messages does
> not succeed, we rely on Kafka's promise to re-deliver the messages.
> But if ZKRebalancerListener triggers a rebalance before our "batch" of
> messages is full, then offsets will be committed even if the messages
> have not been processed yet by our application. So if then processing
> of these messages fails, we basically lost them, right?
> (See discussion at
> http://www.mail-archive.com/[email protected]/msg01415.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
