> On April 13, 2015, 4:16 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines > > 23-35 > > <https://reviews.apache.org/r/33118/diff/1/?file=924969#file924969line23> > > > > Those request names are slightly different from what's in RequestKeys. > > To keep the metric names the same, we need to use the same names as in > > RequestKeys.
Yeah, all request names here are different. It looks like we moved from CamelCase to snake_case (i.e. LeaderAndIsr because leader_and_isr). I think the names are not used anywhere critical in the clients, so they should be safe to change back. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33118/#review79834 ----------------------------------------------------------- On April 13, 2015, 3:39 a.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33118/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 3:39 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2115 > https://issues.apache.org/jira/browse/KAFKA-2115 > > > Repository: kafka > > > Description > ------- > > Modify metrics to use new ApiKeys > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java > 07aba71303bc1303dbe05e4b121f73f7ad27fdb5 > clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java > 9c4518e840904c371a5816bfc52be1933cba0b96 > core/src/main/scala/kafka/network/RequestChannel.scala > 1d9c57b0b5a0ad31e4f3d7562f0266af83cc9024 > > Diff: https://reviews.apache.org/r/33118/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >