-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33420/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2140
https://issues.apache.org/jira/browse/KAFKA-2140
Repository: kafka
Description
-------
Remove redundant `extends Object`
Don't pass `char` to `StringBuilder` constructor
It ends up calling the `StringBuilder(int capacity)` constructor.
Fix `equals` call to use the correct value
Improve numeric coercions
Remove redundant `val` modifiers in case classes
Remove redundant `return` keywords
Remove redundant semi-colons
Use `forall` instead of `foldLeft`
Remove `javaListToScalaBuffer` implicit
No need to support 2.8.x.
Remove unnecessary casts
Remove unnecessary `toSeq`
Simplify boolean logic
Use `sum` instead of `foldLeft`
Use `foreach` instead of `map`
Use `reverseMap` instead of `reverse.map`
Use `contains` and fix comparison to use the same type for both parameters
Also use pattern matching to extract `topic` and `partitions` more concisely.
Remove unnecessary `toInt`
Fix inconsistency in calls to `format`
Remove redundant `toString` call
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
42c72198a0325e234cf1d428b687663099de884e
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java
305ec8ee2b94251c25d0734d3f56495d270744de
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
5a575553d30c1c0bda9ffef9e9b9eafae28deba5
clients/src/main/java/org/apache/kafka/common/metrics/stats/Histogram.java
cf91f5f90660fa9153939b02fcff29131dd58c00
clients/src/main/java/org/apache/kafka/common/protocol/SecurityProtocol.java
d3394ee669e1c2254403e95393511d0a17e6f250
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java
66442ed38533af081897c05292efef4ca58b9bee
clients/src/test/java/org/apache/kafka/common/protocol/types/ProtocolSerializationTest.java
8b926340de49bf6ff0910d129bd680e9e61b26de
contrib/hadoop-consumer/src/main/java/kafka/etl/KafkaETLContext.java
1d0e0a917985736bef7af66c741e5807d8503121
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
bbe3362b2b0eedb79ab80cfe47fd498f6c2941d6
core/src/main/scala/kafka/admin/TopicCommand.scala
60f0228e6735a492315842afe28bcfa317478968
core/src/main/scala/kafka/api/ControlledShutdownRequest.scala
5be393ab8272a49437b5057ed098ccdc42f352e5
core/src/main/scala/kafka/api/ControlledShutdownResponse.scala
5e0a1cf4f407aa859175d619c78d8fec5a0fbd0a
core/src/main/scala/kafka/api/GenericRequestAndHeader.scala
f40e19f4b2ad703e7df8378cb5bd5c78e3b7c6de
core/src/main/scala/kafka/api/GenericResponseAndHeader.scala
a4879e26b5362fb943cdd9768dfca3ad40472405
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala
2fad585f126699ba8d26c901a41bcf6b8198bf62
core/src/main/scala/kafka/api/StopReplicaResponse.scala
3431f3f65d1aea694324d2c9fc8f48e752e70cd6
core/src/main/scala/kafka/api/TopicMetadata.scala
5e39f453b429cb42ab87f695b6b30576f9ce98ce
core/src/main/scala/kafka/api/TopicMetadataRequest.scala
7dca09ce637a40e125de05703dc42e8b611971ac
core/src/main/scala/kafka/client/ClientUtils.scala
b66424b230463df6641a848b99bb73312ea66e33
core/src/main/scala/kafka/cluster/EndPoint.scala
3286f6d4f25ca2118105acbcaf94d308ac0a0c2e
core/src/main/scala/kafka/common/ConsumerReblanceFailedException.scala
core/src/main/scala/kafka/controller/ControllerChannelManager.scala
97acdb23f6e95554c3e0357aa112eddfc875efbc
core/src/main/scala/kafka/controller/KafkaController.scala
3a09377611b48198c4c3cd1a118fc12eda0543d4
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
e5c56e0618a04a2abf8bd02045a458901b75bb1d
core/src/main/scala/kafka/coordinator/DelayedRebalance.scala
8defa2e41c92f1ebe255177679d275c70dae5b3e
core/src/main/scala/kafka/javaapi/Implicits.scala
8baf4d468027a1592273134127768b095c71612f
core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala
0125565c84aeaa345d37ed7e9e259ce7b00816ea
core/src/main/scala/kafka/log/CleanerConfig.scala
ade838672d671549771637e041cdfb22a03b17c1
core/src/main/scala/kafka/log/LogCleaner.scala
12eacdfa7b573988036a8359a156c03b62d22c72
core/src/main/scala/kafka/log/LogConfig.scala
da55a348f37a3d6d99032c39398f7ccb11068f42
core/src/main/scala/kafka/log/OffsetIndex.scala
4ab22deec99dba7ccfffd6d9f5f7a305548eb875
core/src/main/scala/kafka/log/OffsetMap.scala
2940e47cb88e4577adedcc2d2131238e82e589c1
core/src/main/scala/kafka/log/OffsetPosition.scala
6cefde4d90e2885da3fa6e4ee30e738fdbc542fb
core/src/main/scala/kafka/message/MessageSet.scala
f1b8432f4a96fd5c8f9ad273e4b7e1590486e6a4
core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala
30fd0ea3ce061e735214e213ad6270a7f7a6092d
core/src/main/scala/kafka/network/SocketServer.scala
c5fec000f57bed7e1834d085df3c06f54ca9f3d3
core/src/main/scala/kafka/producer/KeyedMessage.scala
388bc9bbd9a69046e9311da6645797b82f5c0854
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala
01e8f72b442be62931553545bc167958357d4b0a
core/src/main/scala/kafka/server/KafkaServer.scala
c63f4ba9d622817ea8636d4e6135fba917ce085a
core/src/main/scala/kafka/server/LogOffsetMetadata.scala
a868334e0e53dc2a0755a732caaf2942e9bc1652
core/src/main/scala/kafka/server/ReplicaManager.scala
8ddd325015de4245fd2cf500d8b0e8c1fd2bc7e8
core/src/main/scala/kafka/tools/ConsoleConsumer.scala
80b26744a79f11ce205fa88f1b75291e11c50bb8
core/src/main/scala/kafka/tools/ConsoleProducer.scala
00265f9f4a4b6c6a9aa023e5be5faf297f77bf31
core/src/main/scala/kafka/tools/ExportZkOffsets.scala
4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportZkOffsets.scala
abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/JmxTool.scala
1d1a120c45ff70fbd60df5b147ca230eb1ef50de
core/src/main/scala/kafka/tools/ProducerPerformance.scala
bc25cd2f371c1b18aba4e7d760357e448acfd5c0
core/src/main/scala/kafka/tools/SimpleConsumerShell.scala
dec9516c76f37a5096976afbef9016d7dbec5d75
core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala
aef8361b73a0934641fc4f5cee942b5b50f3e7d7
core/src/main/scala/kafka/utils/CoreUtils.scala
c473a034bc3a00ccddbbc0506388a5a7763df950
core/src/main/scala/kafka/utils/Mx4jLoader.scala
7417897c5917ba354e410ff865a618e20aa11a52
core/src/main/scala/kafka/utils/Throttler.scala
d1a144d7882919426824799ff8e8a47f89c83158
core/src/main/scala/kafka/utils/ZkUtils.scala
5685a1eddb218baee617161f269cd1aee67bab9f
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
35f4f4612c60e9987e7bedded574d5fc53eba393
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
02d26277b2dad00040cf12da8a3f064c527c871b
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
ab5d16c1d22191708410b15332882ba40eda5f28
core/src/test/scala/unit/kafka/admin/AdminTest.scala
4b728a18a43f851b7ec33ed44b8eb6dd572d6ae2
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
61cc6028dd7c9a2eec2d9cbe6947764655801eee
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala
447e4219f84a8f6805402b4f50f86429571835a1
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala
1113619b7a961cfdb953ffa6979bde9e06f0d2d8
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
5b7b529fdffcf16e8887ff0b082666643ba651d8
core/src/test/scala/unit/kafka/log/LogManagerTest.scala
0a26f5f1549aba299ba22b570a2d29ac651124c6
core/src/test/scala/unit/kafka/log/LogTest.scala
069aa02ab66b24d65774c6c71f02130ee025584d
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
26572f7ff94a71438dd740620018d4dbc3e56970
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala
a67cc37d542de0df0df24224b9d8db5472ecaf27
core/src/test/scala/unit/kafka/utils/IteratorTemplateTest.scala
46a4e899ef293c56a931bfa5bcf9a07d07ec5792
core/src/test/scala/unit/kafka/utils/MockScheduler.scala
c6740782813cbf7c979bf1b94dd829945ef38458
core/src/test/scala/unit/kafka/utils/TestUtils.scala
8dc99b6b9fdf3025a8d77ef19d5d20bb8985cde8
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala
d42108eacf7011688249bc5428cf8a2dec9d9f6e
examples/src/main/java/kafka/examples/SimpleConsumerDemo.java
e5096f03bd34ef7257506afd0d91c866e9c46f6c
Diff: https://reviews.apache.org/r/33420/diff/
Testing
-------
Thanks,
Ismael Juma
