----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33342/#review81617 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/controller/ControllerChannelManager.scala <https://reviews.apache.org/r/33342/#comment132041> Given your latest change, this comment is incorrect. I will take it out during the merge to save time. - Neha Narkhede On April 19, 2015, 7:44 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33342/ > ----------------------------------------------------------- > > (Updated April 19, 2015, 7:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2122 > https://issues.apache.org/jira/browse/KAFKA-2122 > > > Repository: kafka > > > Description > ------- > > KAFKA-2122. Remove controller.message.queue.size Config. > > > Diffs > ----- > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > 97acdb23f6e95554c3e0357aa112eddfc875efbc > core/src/main/scala/kafka/server/KafkaConfig.scala > cfbbd2be550947dd2b3c8c2cab981fa08fb6d859 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > 62d183248e3be4c83d2c768e762f61f92448c6a6 > system_test/mirror_maker_testsuite/config/server.properties > c6284122e3dfaa046a453511c17a19a536dc1035 > system_test/offset_management_testsuite/config/server.properties > 2b988f86052a7bb248e1c7752808cb0a336d0020 > > system_test/offset_management_testsuite/testcase_7002/config/kafka_server_1.properties > 41ec6e49272f129ab11a08aec04faf444f1c4f26 > > system_test/offset_management_testsuite/testcase_7002/config/kafka_server_2.properties > 727e23701d6c2eb08c7ddde198e042921ef058f8 > > system_test/offset_management_testsuite/testcase_7002/config/kafka_server_3.properties > e6fbbe1e0532eb393a5b100c8b3c58be4c546ec0 > > system_test/offset_management_testsuite/testcase_7002/config/kafka_server_4.properties > fee65bce63564a7403d311be2c27c34e17e835a7 > system_test/replication_testsuite/config/server.properties > 6becbab60e3943e56a77dc7872febb9764b2dca9 > > Diff: https://reviews.apache.org/r/33342/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
