-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/
-----------------------------------------------------------
(Updated May 1, 2015, 10:42 p.m.)
Review request for kafka.
Bugs: KAFKA-2121
https://issues.apache.org/jira/browse/KAFKA-2121
Repository: kafka
Description (updated)
-------
override java.io.Closeable$close method in Serializer and Deserializer
interfaces without throwing checked IOException. this is to avoid breaking the
source compatability.
add a test for checking Serializer is closed during KafkaProducer#close
missing copyright header in previous checkin
remvoed "throws Exception" for test methods
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/serialization/Deserializer.java
9a57579f87cb19cb6affe6d157ff8446c23e3551
clients/src/main/java/org/apache/kafka/common/serialization/Serializer.java
c44054038066f0d0829d05f082b2ee42b34cded7
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
eea2c28450736d1668c68828f77a49470a82c3d0
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
49f1427bcbe43c773920a25aa69a71d0329296b7
clients/src/test/java/org/apache/kafka/test/MockMetricsReporter.java
6f948f240c906029a0f972bf770f288f390ea714
clients/src/test/java/org/apache/kafka/test/MockSerializer.java PRE-CREATION
Diff: https://reviews.apache.org/r/33760/diff/
Testing
-------
Thanks,
Steven Wu
