----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33916/#review83264 -----------------------------------------------------------
Ship it! Thanks for the patch. Looks good. Just a couple of minor comments below. core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/33916/#comment134170> Should this be changed from debug to info? core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/33916/#comment134172> Should this be info level logging? - Jun Rao On May 6, 2015, 10:06 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33916/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2163 > https://issues.apache.org/jira/browse/KAFKA-2163 > > > Repository: kafka > > > Description > ------- > > fix > > > renames and logging improvements > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 122b1dbbe45cb27aed79b5be1e735fb617c716b0 > core/src/main/scala/kafka/server/OffsetManager.scala > 18680ce100f10035175cc0263ba7787ab0f6a17a > > Diff: https://reviews.apache.org/r/33916/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
