----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83343 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java <https://reviews.apache.org/r/34070/#comment134315> How does this work if the consumer doesn't own these partitions? Is it possible to commit offsets for any topic? Just curious.. - Aditya Auradkar On May 12, 2015, 1:39 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34070/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 1:39 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2186 > https://issues.apache.org/jira/browse/KAFKA-2186 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-2186 follow-up patch of KAFKA-1650, add the missing offset > commit with map in java api > > > Diffs > ----- > > core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java > cc3400ff81fc0db69b5129ad7b440f20a211a79d > > Diff: https://reviews.apache.org/r/34070/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >