Sounds good. Thanks, Jun. Jiangjie (Becket) Qin
On 5/15/15, 5:21 PM, "Jun Rao" <j...@confluent.io> wrote: >Hi, Jiangjie, > >It seems that api is already in >kafka.javaapi.consumer.ZookeeperConsumerConnector. We just need to add it >to kafka.javaapi.consumer.ConsumerConnector. This is fine and I don't >think >we need a KIP. Since this is only added in trunk, it will be part of the >0.8.3 release. I agree with Joe that since we are developing the new java >consumer, it would be good not to make changes to the old scala consumer. > >As for the the 0.8.3 release, we agreed that it will include at least the >new java consumer. If other features (e.g., security, admin, etc) can be >done at or before that, they will be part of the 0.8.3 release too. >Updated >the release plan wiki. > >Thanks, > >Jun > > >On Wed, May 13, 2015 at 3:01 PM, Jiangjie Qin <j...@linkedin.com.invalid> >wrote: > >> Add the DISCUSS prefix to the email title : ) >> >> From: Jiangjie Qin <j...@linkedin.com<mailto:j...@linkedin.com>> >> Date: Tuesday, May 12, 2015 at 4:51 PM >> To: "dev@kafka.apache.org<mailto:dev@kafka.apache.org>" < >> dev@kafka.apache.org<mailto:dev@kafka.apache.org>> >> Subject: Add missing API to old high level consumer >> >> Hi, >> >> I just noticed that in KAFKA-1650 (which is before we use KIP) we added >>an >> offset commit method in high level consumer that commits offsets using a >> user provided offset map. >> >> public void commitOffsets(Map<TopicPartition, OffsetAndMetadata> >> offsetsToCommit, boolean retryOnFailure); >> >> This method was added to all the Scala classes but I forgot to add it to >> Java API of ConsumerConnector. (Already regretting now. . .) >> This method is very useful in several cases and has been asked for from >> time to time. For example, people have several threads consuming >>messages >> and processing them. Without this method, one thread will unexpectedly >> commit offsets for another thread, thus might lose some messages if >> something goes wrong. >> >> I created KAFKA-2186 and hope we can add this missing method into the >>Java >> API of old high level consumer (literarily one line change). >> Although this method should have been there since KAFKA-1650, adding >>this >> method to Java API now is a public API change, just want to see if >>people >> think we need a KIP for this. >> >> Thanks. >> >> Jiangjie (Becket) Qin >>
