Yeah, that was just a typo. I've fixed it. Thanks for calling it out.
In KIP-4, I believe we have 3 types of requests: CreateTopic, AlterTopic and
DeleteTopic. The topic configs are a sub-type of the Create and Alter commands.
I think it would be nice to simply have a AlterConfig command that can alter
any type of config rather than having a specific ClientConfig.
AlterConfig => [ConfigType [AddedConfigEntry] [DeletedConfig]]
ConfigType => string
AddedConfigEntry => ConfigKey ConfigValue
ConfigKey => string
ConfigValue => string
DeletedConfig => string
The downside of this approach is that we will have 2 separate ways of changing
topic configs (AlterTopic and AlterConfig). While a general AlterConfig only
makes sense if we plan to have more than two types of entity configs.. it's
definitely more future proof. Thoughts?
Aditya
________________________________________
From: Todd Palino [tpal...@gmail.com]
Sent: Monday, May 18, 2015 12:39 PM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-21 Dynamic Configuration
Agree with Jun here on the JSON format. I think your intention was likely
to have actual JSON here and it was just a typo in the wiki?
-Todd
On Mon, May 18, 2015 at 12:07 PM, Jun Rao <j...@confluent.io> wrote:
> Aditya,
>
> Another thing to consider. In KIP-4, we are adding a new RPC request to
> change and retrieve topic configs. Do we want to add a similar RPC request
> to change configs per client id? If so, do we want to introduce a separate
> new request or have a combined new request for both topic and client id
> level config changes?
>
> A minor point in the wiki, for the json format in ZK, we should change
> {X1=Y1,
> X2=Y2..} to a json map, right?
>
> Thanks,
>
> Jun
>
>
> On Mon, May 18, 2015 at 9:48 AM, Aditya Auradkar <
> aaurad...@linkedin.com.invalid> wrote:
>
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
> >
> > Aditya
> >
>
