-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33614/#review88015
-----------------------------------------------------------
Thanks for the patch. There seems to be a compilation error.
:log4j-appender:compileTestJava
/Users/junrao/intellij/kafka/log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java:27:
cannot find symbol
symbol : constructor MockProducer()
location: class org.apache.kafka.clients.producer.MockProducer
private MockProducer mockProducer = new MockProducer();
^
build.gradle
<https://reviews.apache.org/r/33614/#comment140421>
It seems that this is also redundant? Could you fix it in this patch?
checkstyle/import-control.xml
<https://reviews.apache.org/r/33614/#comment140419>
Shouldn't the subpackage be log4jappender?
log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
<https://reviews.apache.org/r/33614/#comment140420>
Capitalize t in topic?
- Jun Rao
On June 14, 2015, 4:19 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33614/
> -----------------------------------------------------------
>
> (Updated June 14, 2015, 4:19 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2132
> https://issues.apache.org/jira/browse/KAFKA-2132
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-2132: Move Log4J appender to clients module
>
>
> Diffs
> -----
>
> build.gradle 30d1cf2f1ff9ed3f86a060da8099bb0774b4cf91
> checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03
> core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala
> 5d36a019e3dbfb93737a9cd23404dcd1c5d836d1
> core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala
> 41366a14590d318fced0e83d6921d8035fa882da
>
> log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
> PRE-CREATION
>
> log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
> PRE-CREATION
>
> log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java
> PRE-CREATION
> settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45
>
> Diff: https://reviews.apache.org/r/33614/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Singh
>
>
