[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593116#comment-14593116
]
Honghai Chen edited comment on KAFKA-1646 at 6/19/15 6:57 AM:
--------------------------------------------------------------
Updated reviewboard https://reviews.apache.org/r/33204/diff/
against branch origin/trunk
The latest code review : https://reviews.apache.org/r/33204/diff/8/
1, fix 2 test cases.
2, fix logCleaner. Whenever create one new file, should set the preallocate
parameter.
3, merge to latest trunk.
Is it ok to go? [~junrao]
Try push some code to open source even harder than play China Shanghai Stock A,
hehe.
was (Author: waldenchen):
Updated reviewboard https://reviews.apache.org/r/33204/diff/
against branch origin/trunk
> Improve consumer read performance for Windows
> ---------------------------------------------
>
> Key: KAFKA-1646
> URL: https://issues.apache.org/jira/browse/KAFKA-1646
> Project: Kafka
> Issue Type: Improvement
> Components: log
> Affects Versions: 0.8.1.1
> Environment: Windows
> Reporter: xueqiang wang
> Assignee: xueqiang wang
> Labels: newbie, patch
> Attachments: Improve consumer read performance for Windows.patch,
> KAFKA-1646-truncate-off-trailing-zeros-on-broker-restart-if-bro.patch,
> KAFKA-1646_20141216_163008.patch, KAFKA-1646_20150306_005526.patch,
> KAFKA-1646_20150511_AddTestcases.patch,
> KAFKA-1646_20150609_MergeToLatestTrunk.patch,
> KAFKA-1646_20150616_FixFormat.patch, KAFKA-1646_20150618_235231.patch
>
>
> This patch is for Window platform only. In Windows platform, if there are
> more than one replicas writing to disk, the segment log files will not be
> consistent in disk and then consumer reading performance will be dropped down
> greatly. This fix allocates more disk spaces when rolling a new segment, and
> then it will improve the consumer reading performance in NTFS file system.
> This patch doesn't affect file allocation of other filesystems, for it only
> adds statements like 'if(Os.iswindow)' or adds methods used on Windows.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
