> On June 19, 2015, 12:11 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 225-227 > > <https://reviews.apache.org/r/35503/diff/1/?file=985641#file985641line225> > > > > Do we still need this now that we have verified the index consistency > > earlier?
Yes, we can remove these statements > On June 19, 2015, 12:11 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, line 178 > > <https://reviews.apache.org/r/35503/diff/1/?file=985641#file985641line178> > > > > Is this correct? The mmapping of the index file happens in the > > initialization of OffsetIndex. It seems that we need to re-create the > > LogSegment after the index file is deleted. index file gets recreated in OffsetIndex.mmap() method (val newlyCreated = file.createNewFile()). So we no need to re-create the LogSegment. Pl check. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/#review88470 ----------------------------------------------------------- On June 19, 2015, 1:27 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35503/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 1:27 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2012 > https://issues.apache.org/jira/browse/KAFKA-2012 > > > Repository: kafka > > > Description > ------- > > Address Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 > core/src/test/scala/unit/kafka/log/LogTest.scala > a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 > > Diff: https://reviews.apache.org/r/35503/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
