[
https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593555#comment-14593555
]
Gwen Shapira commented on KAFKA-2249:
-------------------------------------
Agree that the test is kinda silly now :)
And yes, the printouts were useful when debugging test cases with 1 topic and 1
partition, but PITA in production.
OTOH, printout of non-default config per topic in a debug level "INFO" or
"DEBUG" makes sense IMO (even on large systems) - it can be super useful when
people send logs and ask for help. I'll see if we can do it per topic without
making too much of a mess.
Mind if I take those fixes in separate JIRA?
> KafkaConfig does not preserve original Properties
> -------------------------------------------------
>
> Key: KAFKA-2249
> URL: https://issues.apache.org/jira/browse/KAFKA-2249
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Gwen Shapira
> Fix For: 0.8.3
>
> Attachments: KAFKA-2249.patch, KAFKA-2249_2015-06-17_17:35:35.patch
>
>
> We typically generate configuration from properties objects (or maps).
> The old KafkaConfig, and the new ProducerConfig and ConsumerConfig all retain
> the original Properties object, which means that if the user specified
> properties that are not part of ConfigDef definitions, they are still
> accessible.
> This is important especially for MetricReporters where we want to allow users
> to pass arbitrary properties for the reporter.
> One way to support this is by having KafkaConfig implement AbstractConfig,
> which will give us other nice functionality too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
