[ https://issues.apache.org/jira/browse/KAFKA-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594702#comment-14594702 ]
Aditya Auradkar commented on KAFKA-2238: ---------------------------------------- [~junrao] - KafkaConfig seems to be created in Kafka.scala right before we pass it to the KafkaMetricsReporter using the raw properties object. I guess we cant pass in KafkaConfig directly because the same class is used in the scala clients as well. The only real benefit on adding these properties to KafkaConfig is that they get documented and show up on the release wikis. [~gwenshap] - Took at look at KAFKA-2249. For metrics, are you referring to the config for "metricReporterClasses"? If so, aren't they only for the new metrics package? > KafkaMetricsConfig cannot be configured in broker (KafkaConfig) > --------------------------------------------------------------- > > Key: KAFKA-2238 > URL: https://issues.apache.org/jira/browse/KAFKA-2238 > Project: Kafka > Issue Type: Bug > Reporter: Aditya Auradkar > Assignee: Aditya Auradkar > Attachments: KAFKA-2238.patch > > > All metrics config values are not included in KafkaConfig and consequently > cannot be configured into the brokers. This is because the > KafkaMetricsReporter is passed a properties object generated by calling > toProps on KafkaConfig > KafkaMetricsReporter.startReporters(new > VerifiableProperties(serverConfig.toProps)) > However, KafkaConfig never writes these values into the properties object and > hence these aren't configurable. The defaults always apply > Add the following metrics to KafkaConfig > kafka.metrics.reporters, kafka.metrics.polling.interval.secs, > kafka.csv.metrics.reporter.enabled, kafka.csv.metrics.dir -- This message was sent by Atlassian JIRA (v6.3.4#6332)