----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/#review89971 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java (lines 933 - 937) <https://reviews.apache.org/r/34789/#comment142876> Wondering why we want to fetch for all assigned partitions if the requested partitions is indeed assigned here? clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java (lines 1149 - 1151) <https://reviews.apache.org/r/34789/#comment142873> This comments seems out-dated, or otherwise a bit confusing. clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java (lines 1247 - 1254) <https://reviews.apache.org/r/34789/#comment142874> If the coordinator is not available, would this async commit also be blocked here? Or will this be resolved after we introduced the delayed queue in KAFKA-2123? One minor comments that are out of the scope of this follow-up patch: in Coordinator.handleOffsetResponse, could we rename to handleFetchOffsetResponse? - Guozhang Wang On June 30, 2015, 5:55 p.m., Jason Gustafson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34789/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 5:55 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2168 > https://issues.apache.org/jira/browse/KAFKA-2168 > > > Repository: kafka > > > Description > ------- > > KAFKA-2168; minor fixes > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 9be8fbc648369ad9db1a7eea94bc1b9edbfdbfd7 > core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala > f56096b826bdbf760411a54ba067a6a83eca8a10 > > Diff: https://reviews.apache.org/r/34789/diff/ > > > Testing > ------- > > > Thanks, > > Jason Gustafson > >
