----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90005 -----------------------------------------------------------
Thanks for the patch. A couple more comments. core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala (line 69) <https://reviews.apache.org/r/36030/#comment142931> Do we need this? In tearDown(), ZookeeperTestHarness will delete all ZK data. core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala (lines 157 - 161) <https://reviews.apache.org/r/36030/#comment142932> Could we issue TopicMetadataRequest to every broker and make sure that the correct metadata is propagated to every broker? Ditto in other places as well. - Jun Rao On July 1, 2015, 1:42 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36030/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 1:42 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-972 > https://issues.apache.org/jira/browse/KAFKA-972 > > > Repository: kafka > > > Description > ------- > > KAFKA-972: MetadataRequest returns stale list of brokers > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 36350579b16027359d237b64699003358704ac6f > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 995b05901491bb0dbf0df210d44bd1d7f66fdc82 > > Diff: https://reviews.apache.org/r/36030/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
