[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621174#comment-14621174
]
Onur Karaman commented on KAFKA-1740:
-------------------------------------
Sounds good. Just a heads up, KAFKA-2123 checks if we're PreparingRebalance. A
more accurate check would be if we're not Stable.
So I would suggest the following to handleHeartbeat:
{code}
} else if (generationId != group.generationId || !group.is(Stable)) {
responseCallback(Errors.ILLEGAL_GENERATION.code)
}
{code}
> Merge Offset manager into Coordinator
> -------------------------------------
>
> Key: KAFKA-1740
> URL: https://issues.apache.org/jira/browse/KAFKA-1740
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Priority: Critical
> Fix For: 0.8.3
>
> Attachments: KAFKA-1740.patch, KAFKA-1740_2015-06-29_18:21:42.patch,
> KAFKA-1740_2015-06-29_18:44:54.patch
>
>
> This JIRA involves refactoring offset manager and merge it into coordinator,
> including adding the logic for consumer-id / generation-id checking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
