> On July 6, 2015, 3:50 p.m., Guozhang Wang wrote: > > clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java, > > line 57 > > <https://reviews.apache.org/r/35880/diff/2/?file=999580#file999580line57> > > > > Is this intentional?
yes. Now ClassNotFoundException will be thrown from Utils.newInstance() as KafkaException. > On July 6, 2015, 3:50 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java, line > > 266 > > <https://reviews.apache.org/r/35880/diff/2/?file=999578#file999578line266> > > > > Can we use Utils.newInstance here as well? Here we only need Class Object. > On July 6, 2015, 3:50 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/utils/CoreUtils.scala, line 221 > > <https://reviews.apache.org/r/35880/diff/2/?file=999581#file999581line221> > > > > Can we use scala's Utils.createObject here? Are you sugessting to use Utils.newInstance()? We dont have scala's Utils.scala. Am I missing something? - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90488 ----------------------------------------------------------- On July 6, 2015, 6:05 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35880/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 6:05 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2295 > https://issues.apache.org/jira/browse/KAFKA-2295 > > > Repository: kafka > > > Description > ------- > > Addessing Guozhang's comments > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java > bae528d31516679bed88ee61b408f209f185a8cc > clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java > 4170bcc7def5b50d8aa20e8e84089c35b705b527 > clients/src/main/java/org/apache/kafka/common/utils/Utils.java > af9993cf9b3991f1e61e1201c94e19bc1bf76a68 > > clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java > db1b0ee9113215b5ad7fda0f93915f3bdd34ac55 > core/src/main/scala/kafka/utils/CoreUtils.scala > 168a18d380c200ee566eccb6988dd1ae85ed5b09 > > Diff: https://reviews.apache.org/r/35880/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
