----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/#review91310 -----------------------------------------------------------
Thanks for the patch! core/src/main/scala/kafka/admin/TopicCommand.scala (lines 72 - 73) <https://reviews.apache.org/r/34403/#comment144620> This is a bit unclean. I think its more idiomatic when the catch block includes the System.exit(1). Also, I'm afraid that printing the entire stack trace is intimidating to non-developers who use the CLI. Perhaps the stack trace should go under log.error(...)? - Gwen Shapira On July 10, 2015, 4:34 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34403/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 4:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2198 > https://issues.apache.org/jira/browse/KAFKA-2198 > > > Repository: kafka > > > Description > ------- > > rebase > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > a2ecb9620d647bf8f957a1f00f52896438e804a7 > > Diff: https://reviews.apache.org/r/34403/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
