----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36670/#review92571 -----------------------------------------------------------
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala (line 267) <https://reviews.apache.org/r/36670/#comment146770> You should either include information about the exception that was actually thrown or let the original exception propagate. Also, if you choose the former, you should do `case _: Throwable` to avoid a warning in Scala 2.11. core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala (line 269) <https://reviews.apache.org/r/36670/#comment146771> Should `verifyTopicDeletion` be inside `finally`? I don't think so because you don't want to run it if `fail` is called above. You could move it to be in the `e: TopicAlreadyMarkedForDeletionException` clause maybe? - Ismael Juma On July 22, 2015, 1:46 a.m., Edward Ribeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36670/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 1:46 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2355 > https://issues.apache.org/jira/browse/KAFKA-2355 > > > Repository: kafka > > > Description > ------- > > KAFKA-2355 Add an unit test to validate the deletion of a partition marked as > deleted > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > fa8ce259a2832ab86f9dda8c1d409b2c42d43ae9 > > Diff: https://reviews.apache.org/r/36670/diff/ > > > Testing > ------- > > > Thanks, > > Edward Ribeiro > >
