Oh ok. Is there a plan that we should deprecate the older ones. This is because as I said some users might misconfigure it like by using both the log.retention.ms" and "log.retention.minutes" by mistake. We can probably set a warning that only one of this should be used.
Also looking at the KafkaConfig, it looks like the LogRetentionTimeHours is a required config while the LogRetentionTimeMillis and LogRetentionTimeMinutes are not. Also the doc says this : val LogRetentionTimeMillisDoc = "The number of milliseconds to keep a log file before deleting it (in milliseconds)" val LogRetentionTimeMinsDoc = "The number of minutes to keep a log file before deleting it (in minutes), secondary to " + LogRetentionTimeMillisProp + " property" val LogRetentionTimeHoursDoc = "The number of hours to keep a log file before deleting it (in hours), tertiary to " + LogRetentionTimeMillisProp + " property" So if my understanding is correct, LogRetentionTimeHours takes precedence over all of the other. Am I right? Thanks, Mayuresh On Fri, Jul 24, 2015 at 6:49 PM, Gwen Shapira <gshap...@cloudera.com> wrote: > Backward compatibility, I think. > > At least the "ms" one is fairly new, and I think we left the others to > avoid break configuration during upgrade. > > On Fri, Jul 24, 2015 at 6:34 PM, Mayuresh Gharat > <gharatmayures...@gmail.com> wrote: > > I was thinking why we have 3 different configs for the same property (log > > retention) : > > > > "log.retention.ms" > > "log.retention.minutes" > > "log.retention.hours" > > > > Why don't we only use the Milliseconds? > > There are other properties as well like log Jitter, LogRollTime which > raise > > the same question in my mind. > > > > The reason I am asking this is that a user might misconfigure them like > > setting the log.retention.ms = 1 and log.retention.hours = 1. > > > > -- > > -Regards, > > Mayuresh R. Gharat > > (862) 250-7125 > -- -Regards, Mayuresh R. Gharat (862) 250-7125
