----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93213 -----------------------------------------------------------
Ouch. Hard to believe this wasn't caught yet. core/src/test/scala/integration/kafka/api/ConsumerTest.scala (line 220) <https://reviews.apache.org/r/36871/#comment147533> Could we catch this issue more directly with a unit test for SubscriptionState? - Jason Gustafson On July 28, 2015, 12:56 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36871/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 12:56 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2381 > https://issues.apache.org/jira/browse/KAFKA-2381 > > > Repository: kafka > > > Description > ------- > > KAFKA-2381: Possible ConcurrentModificationException while unsubscribing from > a topic in new consumer > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java > 4d9a425201115a66b457b58d670992b279091f5a > core/src/test/scala/integration/kafka/api/ConsumerTest.scala > 3eb5f95731a3f06f662b334ab2b3d0ad7fa9e1ca > > Diff: https://reviews.apache.org/r/36871/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
