[ 
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649523#comment-14649523
 ] 

Ismael Juma commented on KAFKA-1690:
------------------------------------

[~harsha_ch], I just meant whether it should be merged as it is, or if the 
remaining issues should be handled first. Nothing more. :) I think you took my 
comment to mean more than I meant.

IMO the reason why comments keep coming up is because the patch is very large 
and people miss things. There have been a number of studies on this.

Regarding style issues, I don't understand why big patches should have a 
different standard than small ones. Not my call though.

> new java producer needs ssl support as a client
> -----------------------------------------------
>
>                 Key: KAFKA-1690
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1690
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Joe Stein
>            Assignee: Sriharsha Chintalapani
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1690.patch, KAFKA-1690.patch, 
> KAFKA-1690_2015-05-10_23:20:30.patch, KAFKA-1690_2015-05-10_23:31:42.patch, 
> KAFKA-1690_2015-05-11_16:09:36.patch, KAFKA-1690_2015-05-12_16:20:08.patch, 
> KAFKA-1690_2015-05-15_07:18:21.patch, KAFKA-1690_2015-05-20_14:54:35.patch, 
> KAFKA-1690_2015-05-21_10:37:08.patch, KAFKA-1690_2015-06-03_18:52:29.patch, 
> KAFKA-1690_2015-06-23_13:18:20.patch, KAFKA-1690_2015-07-20_06:10:42.patch, 
> KAFKA-1690_2015-07-20_11:59:57.patch, KAFKA-1690_2015-07-25_12:10:55.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to