[ https://issues.apache.org/jira/browse/KAFKA-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652297#comment-14652297 ]
ASF GitHub Bot commented on KAFKA-2399: --------------------------------------- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/106 KAFKA-2399; Replace `Stream.continually` with `Iterator.continually` `Iterator.continually` is more efficient (it doesn't allocate a `Cons` instance per element) and we don't need the extra functionality provided by `Stream.continually`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-2399-replace-stream-continually Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/106.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #106 ---- commit 68531ed09d4bf7f263e07c4d410dc1916d85666c Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-03T18:54:04Z Replace `Stream.continually` with `Iterator.continually` ---- > Replace Stream.continually with Iterator.continually > ---------------------------------------------------- > > Key: KAFKA-2399 > URL: https://issues.apache.org/jira/browse/KAFKA-2399 > Project: Kafka > Issue Type: Bug > Reporter: Ismael Juma > Priority: Minor > > There are two usages of `Stream.continually` and neither of them seems to > need the extra functionality it provides over `Iterator.continually` > (`Stream.continually` allocates `Cons` instances to save the computation > instead of recomputing it if needed more than once). -- This message was sent by Atlassian JIRA (v6.3.4#6332)