----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35677/#review94164 -----------------------------------------------------------
Ship it! Looks good to me. +1. Just a minor comment below. core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala (lines 388 - 398) <https://reviews.apache.org/r/35677/#comment148699> Is this test really needed? KafkaConfig.fromProps() just calls the constructor of KafkaConfig. - Jun Rao On Aug. 4, 2015, 11:19 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35677/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 11:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2288 > https://issues.apache.org/jira/browse/KAFKA-2288 > > > Repository: kafka > > > Description > ------- > > rebased and added equals to AbstractConfig to make tests more concise > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java > ec3ae15ec78fb82599543125917071e1f8485eb0 > core/src/main/scala/kafka/log/LogConfig.scala > fc41132d2bf29439225ec581829eb479f98cc416 > core/src/test/scala/unit/kafka/log/LogConfigTest.scala > 19dcb47f3f406b8d6c3668297450ab6b534e4471 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > 04a02e08a54139ee1a298c5354731bae009efef3 > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > d3544526b66ce1f146f6986401299da9ebe49cd4 > > Diff: https://reviews.apache.org/r/35677/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
