[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662559#comment-14662559
]
Gwen Shapira commented on KAFKA-2389:
-------------------------------------
Why are we not making the API identical to KafkaProducer.send()? (A commit is
kind of a send...)
Allow (but not force) a callback, and also return a future so a sync client can
wait on it. This has the advantage of some consistency between our client APIs.
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
