[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705537#comment-14705537
]
Parth Brahmbhatt commented on KAFKA-2210:
-----------------------------------------
[~ijuma] [~junrao] Thanks for the review and sorry for the bad quality in last
patch. The code wont compile at this point as I have removed KAFKA-1683
changes from this patch and this patch depends on changes from KAFKA-1683. If
you apply the old patch from KAFKA-1683 it should compile and locally all the
tests passed for me.
[~ijuma] I had every intention to just have authorizer call at top level in the
switch case where we multiplex. Realized early on that it won't be possible
given we don't have a common TopicRequest method and even though we have a top
level response class some API's return their extensions even for error cases.
In addition some of the methods need to verify topics , some topics and groups
and some topics and cluster and sometimes there are side effects like topic
creation. For the partition method, the best we might be able to do is create a
method that would look awfully similar to authorize method but will take care
of not duplicating boilerplate az.map().getOrElse() which IMO is not vastly
different nor does it make the code more readable.
Let me know if you come up with something better and I will be happy to
incorporate your suggestion, I will also try the same on my end.
> KafkaAuthorizer: Add all public entities, config changes and changes to
> KafkaAPI and kafkaServer to allow pluggable authorizer implementation.
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2210
> URL: https://issues.apache.org/jira/browse/KAFKA-2210
> Project: Kafka
> Issue Type: Sub-task
> Components: security
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Fix For: 0.8.3
>
> Attachments: KAFKA-2210.patch, KAFKA-2210_2015-06-03_16:36:11.patch,
> KAFKA-2210_2015-06-04_16:07:39.patch, KAFKA-2210_2015-07-09_18:00:34.patch,
> KAFKA-2210_2015-07-14_10:02:19.patch, KAFKA-2210_2015-07-14_14:13:19.patch,
> KAFKA-2210_2015-07-20_16:42:18.patch, KAFKA-2210_2015-07-21_17:08:21.patch,
> KAFKA-2210_2015-08-10_18:31:54.patch, KAFKA-2210_2015-08-20_11:27:18.patch
>
>
> This is the first subtask for Kafka-1688. As Part of this jira we intend to
> agree on all the public entities, configs and changes to existing kafka
> classes to allow pluggable authorizer implementation.
> Please see KIP-11
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface
> for detailed design.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
