[
https://issues.apache.org/jira/browse/KAFKA-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707249#comment-14707249
]
Gwen Shapira commented on KAFKA-2412:
-------------------------------------
Thank you for contributing! Documenting our configuration and producer behavior
is super important, so I appreciate you taking this on.
I have two content related comments:
1. I'm not sure your recommendations for "commonly used" are actually common...
Perhaps just pointing to the default implementations will be clear enough?
Especially regarding String for value... I feel like we are pointing people
toward an implementation we don't necessarily recommend.
2. Your explanation for "in-flight" uses the term "in-flight", perhaps it can
be made more clear? I'm not sure how common this term is.
I don't really see where increasing this number can cause suboptimal batching.
The "waiting for batches" behavior is controlled in linger.ms.
Also, some warning that high in-flight value will increase throughput but can
cause out-of-order arrivals?
> Documentation bug: Add information for key.serializer and value.serializer to
> New Producer Config sections
> ----------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2412
> URL: https://issues.apache.org/jira/browse/KAFKA-2412
> Project: Kafka
> Issue Type: Bug
> Reporter: Jeremy Fields
> Assignee: Grayson Chao
> Priority: Minor
> Labels: newbie
> Attachments: KAFKA-2412.diff
>
>
> As key.serializer and value.serializer are required options when using the
> new producer, they should be mentioned in the documentation ( here and svn
> http://kafka.apache.org/documentation.html#newproducerconfigs )
> Appropriate values for these options exist in javadoc and producer.java
> examples; however, not everyone is reading those, as is the case for anyone
> setting up a producer.config file for mirrormaker.
> A sensible default should be suggested, such as
> org.apache.kafka.common.serialization.StringSerializer
> Or at least a mention of the key.serializer and value.serializer options
> along with a link to javadoc
> Thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
