[
https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709794#comment-14709794
]
Edward Ribeiro edited comment on KAFKA-1811 at 8/24/15 6:42 PM:
----------------------------------------------------------------
Hi [~gwenshap] and [~nehanarkhede], I have just uploaded a first cut to address
this issue. I looked for a ready ZK lock recipe, but couldn't find one in
either ZkClient nor Kafka, so I rolled out one. Hopefully, as Curator is
integrated into Kafka we will have the chance of replacing it by a superior
implementation. :) If [~fpj] could take a look at my naive ZKLock, I would be
really glad. ;) As this patch touches a critical code path, I had to adjust it
as some unit tests failing (mainly the time sensitive ones), but I didn't have
the opportunity to run all the test suite, so any feedback about this is
welcome. Please, let me know if this patch is really worth.
update: this is my last use of old review process, gonna switch to Github next.
:)
Thanks!
was (Author: eribeiro):
Hi [~gwenshap] and [~nehanarkhede], I have just uploaded a first cut to address
this issue. I looked for a ready ZK lock recipe, but couldn't find one in
either ZkClient nor Kafka, so I rolled out one. Hopefully, as Curator is
integrated into Kafka we will have the chance of replacing it by a superior
implementation. :) If [~fpj] could take a look at my naive ZKLock, I would be
really glad. ;) As this patch touches a critical code path, I had to adjust it
as some unit tests failing (mainly the time sensitive ones), but I didn't have
the opportunity to run all the test suite, so any feedback about this is
welcome. Please, let me know if this patch is really worth.
Thanks!
> ensuring registered broker host:port is unique
> ----------------------------------------------
>
> Key: KAFKA-1811
> URL: https://issues.apache.org/jira/browse/KAFKA-1811
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jun Rao
> Assignee: Edward Ribeiro
> Labels: newbie
> Attachments: KAFKA-1811.patch, KAFKA_1811.patch
>
>
> Currently, we expect each of the registered broker to have a unique host:port
> pair. However, we don't enforce that, which causes various weird problems. It
> would be useful to ensure this during broker registration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
