[
https://issues.apache.org/jira/browse/KAFKA-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710666#comment-14710666
]
ASF GitHub Bot commented on KAFKA-2467:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/166
KAFKA-2467: Fix changes to behavior in ConsoleConsumer: properly parse
consumer.config option, handle exceptions during message processing, and print
number of processed messages to stderr.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka
kafka-2467-fix-console-consumer-behavior-regressions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit a6961ee0c7551b69922a43ca91f8146662e21209
Author: Ewen Cheslack-Postava <[email protected]>
Date: 2015-08-25T05:50:12Z
KAFKA-2467: Fix changes to behavior in ConsoleConsumer: properly parse
consumer.config option, handle exceptions during message processing, and print
number of processed messages to stderr.
----
> ConsoleConsumer regressions
> ---------------------------
>
> Key: KAFKA-2467
> URL: https://issues.apache.org/jira/browse/KAFKA-2467
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
>
> It seems that the patch for KAFKA-2015 caused a few changes in the behavior
> of the console consumer. I picked this up because it caused the new mirror
> maker sanity system test to hang. We need a separate fix for ducktape to
> address the lack of a timeout where it got stuck, but I'd also like to get
> this fixed ASAP since it affects pretty much all system test efforts since
> they commonly use console consumer to validate data produced to Kafka.
> I've tracked down a couple of changes so far:
> 1. The --consumer.config option handling was changed entirely. I think the
> new approach was trying to parse it as key=value parameters, but it's
> supposed to be a properties file *containing* key=value pairs.
> 2. A few different exceptions during message processing are not handled the
> same way. The skipMessageOnErrorOpt is not longer being used at all (it's
> parsed, but that option is never checked anymore). Also, exceptions during
> iteration are not caught. After fixing the consumer.config issue, which was
> keeping the consumer.timeout.ms setting from making it into the consumer
> config, this also caused the process to hang. It killed the main thread, but
> there must be another non-daemon thread still running (presumably the
> consumer threads?)
> 3. The "consumed X messages" message changed from stderr to stdout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
