[ 
https://issues.apache.org/jira/browse/KAFKA-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717551#comment-14717551
 ] 

ASF GitHub Bot commented on KAFKA-2475:
---------------------------------------

GitHub user ewencp opened a pull request:

    https://github.com/apache/kafka/pull/172

    KAFKA-2475: Make Copycat only have a Converter class instead of Serializer, 
Deserializer, and Converter.

    The Converter class now translates directly between byte[] and Copycat's 
data
    API instead of requiring an intermediate runtime type like Avro's 
GenericRecord
    or Jackson's JsonNode.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ewencp/kafka 
kafka-2475-unified-serializer-converter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #172
    
----
commit 4bed051e56ef0c55cf11bae59844221f68d18b42
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date:   2015-08-26T19:08:17Z

    KAFKA-2475: Make Copycat only have a Converter class instead of Serializer, 
Deserializer, and Converter.
    
    The Converter class now translates directly between byte[] and Copycat's 
data
    API instead of requiring an intermediate runtime type like Avro's 
GenericRecord
    or Jackson's JsonNode.

----


> Reduce copycat configs to only specify a converter or serializer, not both
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-2475
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2475
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: copycat
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.8.3
>
>
> Ultimately, all we care about is getting from byte[] -> Copycat data API. The 
> current split of the interfaces makes it easy to reuse existing serializers, 
> but you still have to implement a new class.
> It will be simpler, both conceptually and by requiring fewer configs, to 
> combine both these steps into a single API. This also allows certain formats 
> to preserve more information across these (e.g. for primitive types in 
> schema, which otherwise could lose certain schema information).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to