[
https://issues.apache.org/jira/browse/KAFKA-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730330#comment-14730330
]
Ewen Cheslack-Postava commented on KAFKA-2513:
----------------------------------------------
[~singhashish] Compile tasks don't generate something that can be run via the
normal scripts. To use any of the normal tooling, you need to {{jar}}. I'm all
for automated validation of code, but it should be a barrier to getting code
checked in, not to me being able to run in-development code on my local machine.
I'm pretty vocal about stuff like this because it can have a huge impact on
developer efficiency. It can actually take me significantly longer to clean up
some crappy test/debugging code than it would to run the *system test* I'm
trying to run to debug or validate some code. I really don't want a tool that's
intended to make sure we don't *check in* bad code to get in the way of me
iterating locally on dev code.
(If it's not obvious, there are a couple of rules that, by muscle memory, I
consistently fail. They include:
1. for in for loops must have a space between "for" and the paranthesis
2. casts must have spaces after them as well
3. You're not allowed to put parentheses around ternary operators unless they
are absolutely required. I actually think we should remove this one, it really
hurts clarity in some cases.
)
> Checkstyle is not executed until gradle's tests phase
> -----------------------------------------------------
>
> Key: KAFKA-2513
> URL: https://issues.apache.org/jira/browse/KAFKA-2513
> Project: Kafka
> Issue Type: Bug
> Reporter: Ashish K Singh
> Assignee: Ashish K Singh
> Priority: Minor
>
> Checkstyle is added as a dependency to test and until someone runs test they
> won't capture checkstyle issues. To me code style is more suited along with
> compile than tests. This was also brought up on KAFKA-1893. May be we should
> make checkstyle a dependency of jar, instead of test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
