[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742109#comment-14742109
]
Andrii Biletskyi commented on KAFKA-2229:
-----------------------------------------
Sorry I was on vacation so didn't have time to work on this issue. I think I
resolved all your comments now I need to rebase changes to the trunk and commit
corresponding fixes per your comments. It's been a while since last rebase, but
still I think it will be quicker if I do it.
Your help will be very appreciated in reviewing again after rebase. As I can
see there were some changes in replica assignment code which my changes use a
lot, this part is pretty critical. Also you could provide more details (or even
recommendations) to your comment
"This logic is fairly complex and difficult to track. I am not sure the best
way to resolve it. Breaking it into smaller functions may help."
-> I've updated on it in RB.
Thanks,
Andrii
> Phase 1: Requests and KafkaApis
> -------------------------------
>
> Key: KAFKA-2229
> URL: https://issues.apache.org/jira/browse/KAFKA-2229
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Andrii Biletskyi
> Assignee: Andrii Biletskyi
> Attachments: KAFKA-2229.patch, KAFKA-2229_2015-06-30_16:59:17.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
