[
https://issues.apache.org/jira/browse/KAFKA-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2557:
--------------------------------
Description:
The ILLEGAL_GENERATION error is a bit confusing today. When a consumer receives
an ILLEGAL_GENERATION from hearbeat response, it should still use that
generation id to commit offset. i.e. the generation id was not really illegal.
The current code was written earlier when we still bump up the generation id
when the coordinator enters PrepareRebalance state. Since now the generation id
is bumped up after PreareRebalance state ends, we should not overload
ILLEGAL_GENERATION to notify a rebalance but create a new error code such as
REBALANCE_IN_PROGRESS.
was:
The IllegalGenerationIdException is a bit confusing today. When a consumer
receives an IllegalGenerationIdException from hearbeat response, it should
still use that generation id to commit offset. i.e. the generation ID was not
really illegal.
The current code was written earlier when we still bump up the generation ID
when the coordinator enters PrepareRebalance state. Since now the generation ID
is bumped up after PreareRebalance state ends, we should not overload
IllegalGenerationIdException to notify a rebalance but create a new error code
such as RebalanceNeededException.
> Separate RebalanceInProgress from IllegalGeneration Error Code
> --------------------------------------------------------------
>
> Key: KAFKA-2557
> URL: https://issues.apache.org/jira/browse/KAFKA-2557
> Project: Kafka
> Issue Type: Bug
> Components: clients, consumer
> Reporter: Jiangjie Qin
> Assignee: Onur Karaman
>
> The ILLEGAL_GENERATION error is a bit confusing today. When a consumer
> receives an ILLEGAL_GENERATION from hearbeat response, it should still use
> that generation id to commit offset. i.e. the generation id was not really
> illegal.
> The current code was written earlier when we still bump up the generation id
> when the coordinator enters PrepareRebalance state. Since now the generation
> id is bumped up after PreareRebalance state ends, we should not overload
> ILLEGAL_GENERATION to notify a rebalance but create a new error code such as
> REBALANCE_IN_PROGRESS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
