[
https://issues.apache.org/jira/browse/KAFKA-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876666#comment-14876666
]
ASF GitHub Bot commented on KAFKA-2557:
---------------------------------------
GitHub user onurkaraman opened a pull request:
https://github.com/apache/kafka/pull/222
KAFKA-2557: separate REBALANCE_IN_PROGRESS and ILLEGAL_GENERATION error
codes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/onurkaraman/kafka KAFKA-2557
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #222
----
commit f92a9f73b5bb8e7b69c682e49bf58ea45bc27154
Author: Onur Karaman <[email protected]>
Date: 2015-09-18T22:35:10Z
separate REBALANCE_IN_PROGRESS and ILLEGAL_GENERATION error codes
----
> Separate RebalanceInProgress from IllegalGeneration Error Code
> --------------------------------------------------------------
>
> Key: KAFKA-2557
> URL: https://issues.apache.org/jira/browse/KAFKA-2557
> Project: Kafka
> Issue Type: Bug
> Components: clients, consumer
> Reporter: Jiangjie Qin
> Assignee: Onur Karaman
>
> The ILLEGAL_GENERATION error is a bit confusing today. When a consumer
> receives an ILLEGAL_GENERATION from hearbeat response, it should still use
> that generation id to commit offset. i.e. the generation id was not really
> illegal.
> The current code was written earlier when we still bump up the generation id
> when the coordinator enters PrepareRebalance state. Since now the generation
> id is bumped up after PreareRebalance state ends, we should not overload
> ILLEGAL_GENERATION to notify a rebalance but create a new error code such as
> REBALANCE_IN_PROGRESS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
