[
https://issues.apache.org/jira/browse/KAFKA-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968229#comment-14968229
]
ASF GitHub Bot commented on KAFKA-2677:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/349
KAFKA-2677 [WIP]: ensure consumer sees coordinator disconnects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-2677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit db8b4666e64dbb99980df038569b9dd474b55bb8
Author: Jason Gustafson <[email protected]>
Date: 2015-10-22T00:02:05Z
KAFKA-2677 [WIP]: ensure consumer sees coordinator disconnects
----
> Coordinator disconnects not propagated to new consumer
> ------------------------------------------------------
>
> Key: KAFKA-2677
> URL: https://issues.apache.org/jira/browse/KAFKA-2677
> Project: Kafka
> Issue Type: Bug
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
>
> Currently, disconnects by the coordinator are not always seen by the
> consumer. This can result in a long delay after the old coordinator has
> shutdown or failed before the consumer knows that it needs to find the new
> coordinator. The NetworkClient makes socket disconnects available to users in
> two ways:
> 1. through a flag in the ClientResponse object for requests pending when the
> disconnect occurred, and
> 2. through the connectionFailed() method.
> The first method clearly cannot be depended on since it only helps when a
> request is pending, which is relatively rare for the connection with the
> coordinator. Instead, we can probably use the second method with a little
> rework of ConsumerNetworkClient to check for failed connections immediately
> after returning from poll().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
