[
https://issues.apache.org/jira/browse/KAFKA-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976747#comment-14976747
]
ASF GitHub Bot commented on KAFKA-2663:
---------------------------------------
GitHub user auradkar opened a pull request:
https://github.com/apache/kafka/pull/369
KAFKA-2663, KAFKA-2664 - [Minor] Bugfixes
This has 2 fixes:
KAFKA-2664 - This patch changes the underlying map implementation of
Metrics.java to a ConcurrentHashMap. Using a CopyOnWriteMap caused new metrics
creation to get extremely slow when the existing corpus of metrics is large.
Using a ConcurrentHashMap seems to speed up metric creation time significantly
KAFKA-2663 - Splitting out the throttleTime from the remote time. On
throttled requests, the remote time went up artificially.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/auradkar/kafka K-2664
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/369.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #369
----
commit 2dc50c39bb9ea2c29d4d7663cacc145bf4bcd758
Author: Aditya Auradkar <[email protected]>
Date: 2015-10-27T16:29:29Z
Fix for KAFKA-2664, KAFKA-2663
commit f3abc741312a33fc2aba011fbc179519749af439
Author: Aditya Auradkar <[email protected]>
Date: 2015-10-27T17:06:47Z
revert gradle changes
----
> Add quota-delay time to request processing time break-up
> --------------------------------------------------------
>
> Key: KAFKA-2663
> URL: https://issues.apache.org/jira/browse/KAFKA-2663
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Aditya Auradkar
> Fix For: 0.9.0.1
>
>
> This is probably not critical for 0.9 but should be easy to fix:
> If a request is delayed due to quotas, I think the remote time will go up
> artificially - or maybe response queue time (haven’t checked). We should add
> a new quotaDelayTime to the request handling time break-up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
